🐛[maykinmedia/open-api-framework#39] make user emails unique #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
force-pushed
the
feature/OAF#39-user-email-unique
branch
from
f5342fa to
70bda4e
Compare
4 tasks
annashamray
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Should we add some code to check if existing emails are unique?
@stevenbal @Coperh what do you think?
|
@annashamray hmm yeah, though I'm not sure what that check would do if it finds that there are duplicate emails 🤔 |
|
@stevenbal Maybe just some warning in the CHANGELOG for devops? So if migrations fail they will know why |
|
I think that's a good idea 👍 |
|
@annashamray @stevenbal Added a warning to the changelog. Just want a review of this before I copy pasta it to my other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: maykinmedia/open-api-framework#39