Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several components allow logging in with email + password while User.email is not unique #39

Closed
4 tasks done
stevenbal opened this issue Jun 28, 2024 · 3 comments · Fixed by open-zaak/open-notificaties#169, maykinmedia/open-klant#199, maykinmedia/objects-api#422 or maykinmedia/objecttypes-api#120
Closed
4 tasks done

Several components allow logging in with email + password while User.email is not unique #39

stevenbal opened this issue Jun 28, 2024 · 3 comments · Fixed by open-zaak/open-notificaties#169, maykinmedia/open-klant#199, maykinmedia/objects-api#422 or maykinmedia/objecttypes-api#120
Assignees
@Coperh
Labels
bug Something isn't working owner: maykin

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Jun 28, 2024 •
edited by Coperh
Loading

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

I noticed that several components support the UserModelEmailBackend, even though email is not a unique attribute of the User model. This leads to errors if you try to login with an email that is used by one or more users

Stappen om te reproduceren / Steps to reproduce

  1. Create two users with the same email [email protected]
  2. Log in with [email protected] and a password
  3. Observe the error

Verwacht gedrag / Expected behavior

Since Open Zaak and Referentielijsten have a constraint on this, I would expect this to be used in the other components as well https://github.com/open-zaak/open-zaak/blob/72e9025f1f924d1ffcd5ab6f83df58e3696f622b/src/openzaak/accounts/models.py#L50-L54
@stevenbal stevenbal added bug Something isn't working triage Triage means the team has not yet refined this issue. labels Jun 28, 2024
@joeribekker joeribekker removed the triage Triage means the team has not yet refined this issue. label Jul 2, 2024
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Jul 2, 2024
@joeribekker
Copy link
Member

Please also check if this is an issue in default project.

@Coperh Coperh moved this from Todo to In Progress in Data en API fundament Jul 2, 2024
Coperh added a commit to open-zaak/open-notificaties that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
6525f7a
@Coperh Coperh mentioned this issue Jul 2, 2024
Merged
Coperh added a commit to maykinmedia/open-klant that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
ca27bda
@Coperh Coperh mentioned this issue Jul 2, 2024
Merged
Coperh added a commit to maykinmedia/open-klant that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
49d7525
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
420c78e
@Coperh Coperh mentioned this issue Jul 2, 2024
Merged
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
b4e9864
Coperh added a commit to maykinmedia/objecttypes-api that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
f5342fa
@Coperh Coperh mentioned this issue Jul 2, 2024
Merged
Coperh added a commit to maykinmedia/objecttypes-api that referenced this issue Jul 2, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
70bda4e
@Coperh
Copy link
Contributor

Coperh commented Jul 2, 2024

Copy pasta

@Coperh Coperh moved this from In Progress to Implemented in Data en API fundament Jul 2, 2024
Coperh added a commit to maykinmedia/objecttypes-api that referenced this issue Jul 5, 2024
@Coperh
📝[maykinmedia/open-api-framework#39] add warning to the changelog
254288d
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 5, 2024
@Coperh
📝[maykinmedia/open-api-framework#39] add warning to the changelog
23e784d
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 5, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
1c9dd09
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 5, 2024
@Coperh
📝[maykinmedia/open-api-framework#39] add warning to the changelog
c3d523a
Coperh added a commit to maykinmedia/open-klant that referenced this issue Jul 5, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
92cba20
Coperh added a commit to maykinmedia/open-klant that referenced this issue Jul 5, 2024
@Coperh
📝[maykinmedia/open-api-framework#39] add warning to the changelog
ed48538
Coperh added a commit to open-zaak/open-notificaties that referenced this issue Jul 5, 2024
@Coperh
🐛[maykinmedia/open-api-framework#39] make user emails unique
0c59ae6
Coperh added a commit to open-zaak/open-notificaties that referenced this issue Jul 5, 2024
@Coperh
📝[maykinmedia/open-api-framework#39] add warning to the changelog
7b9255d
Coperh added a commit to maykinmedia/objecttypes-api that referenced this issue Jul 5, 2024
@Coperh
Merge pull request #120 from maykinmedia/feature/OAF#39-user-email-un…
2911467 
…ique

🐛[maykinmedia/open-api-framework#39] make user emails unique
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Jul 5, 2024
@Coperh Coperh reopened this Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Jul 5, 2024
@Coperh Coperh moved this from In Progress to Implemented in Data en API fundament Jul 5, 2024
Coperh added a commit to open-zaak/open-notificaties that referenced this issue Jul 5, 2024
@Coperh
Merge pull request #169 from open-zaak/feature/OAF#39-user-email-unique
ad8a7ff 
🐛[maykinmedia/open-api-framework#39] make user emails unique
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Jul 5, 2024
Coperh added a commit to maykinmedia/objects-api that referenced this issue Jul 5, 2024
@Coperh
Merge pull request #422 from maykinmedia/feature/OAF#39-user-email-un…
3352a74 
…ique

🐛[maykinmedia/open-api-framework#39] make user emails unique
@Coperh Coperh reopened this Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Jul 5, 2024
@Coperh Coperh moved this from In Progress to Implemented in Data en API fundament Jul 5, 2024
Coperh added a commit to maykinmedia/open-klant that referenced this issue Jul 5, 2024
@Coperh
Merge pull request #199 from maykinmedia/feature/OAF#39-user-email-un…
4879c26 
…ique

🐛[maykinmedia/open-api-framework#39] make user emails unique
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Jul 5, 2024
@Coperh
Copy link
Contributor

Coperh commented Jul 5, 2024

Also fixed in the default project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coperh Coperh

Labels
bug Something isn't working owner: maykin
Projects
Data en API fundament
Status: Done
Milestone
No milestone
3 participants
@joeribekker @Coperh @stevenbal