chore(react-native-example): upgrade example app & fix detox tests #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-pearson-mattr
changed the title
thomas-pearson-mattr
force-pushed
the
tp/SNYK-1397/fix-example-plus-flipper
branch
3 times, most recently
from
a4f67c3 to
4b0bdf1
Compare
...a/com/example/mattrglobalpairingcryptorn/newarchitecture/MainApplicationReactNativeHost.java
Outdated
Show resolved
Hide resolved
...le/android/app/src/debug/java/com/example/mattrglobalpairingcryptorn/ReactNativeFlipper.java
Outdated
Show resolved
Hide resolved
thomas-pearson-mattr
force-pushed
the
tp/SNYK-1397/fix-example-plus-flipper
branch
from
81c425b to
21ade55
Compare
thomas-pearson-mattr
changed the title
...a/com/example/mattrglobalpairingcryptorn/newarchitecture/MainApplicationReactNativeHost.java
Outdated
Show resolved
Hide resolved
...le/android/app/src/debug/java/com/example/mattrglobalpairingcryptorn/ReactNativeFlipper.java
Outdated
Show resolved
Hide resolved
React native was upgraded but wasn't migrated when updating from 0.68.2 Have applied the changes for IOS https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.72.14
- Pin rust toolchain as getting undefined symbols for aarch64-apple-ios + #231 (comment) - Install iPhone 11 - Use headless emulation for CI ci(detox-ios): try removing xcode pin
React native was upgraded but wasn't migrated when updating from 0.68.2 Have applied the changes for Android https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.72.14
- Switch to using ubuntu for the runner - Replace deprecated joschi/setup-jdk with standard java Github action helper. - Use reactivecircus/android-emulator-runner emulator helper and enable KVM - Try another port for emulator as 5554 is causing conflicts - Add retries since sometime detox can be flaky - Stick with API to 29 for now until the main package is updated
IOS detox tests kept failing due to this issue wix/Detox#4148. Upgrading resolves the issue and things are bit faster now!
thomas-pearson-mattr
force-pushed
the
tp/SNYK-1397/fix-example-plus-flipper
branch
3 times, most recently
from
0820a6a to
c455532
Compare
thomas-pearson-mattr
force-pushed
the
tp/SNYK-1397/fix-example-plus-flipper
branch
from
c455532 to
4fdf376
Compare
afonsobarracha
previously approved these changes
Dec 9, 2024
mate-from-mattr
previously approved these changes
Dec 9, 2024
thomas-pearson-mattr
dismissed stale reviews from mate-from-mattr and afonsobarracha
via
8391533
mate-from-mattr
approved these changes
Dec 10, 2024
thomas-pearson-mattr
deleted the
tp/SNYK-1397/fix-example-plus-flipper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch react-native wrapper example by migrating to react native
0.72.14package.json was updated to use the newer react-native version but Android and IOS where not migrated accidentally.We will need to update the core react-native wrapper this is just for the example have already gone out of scope so can pick this up later 😄
Have applied the diff from the migration tool
https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.72.14 and have left comments to explain any outliers outside of this diff that we need for this project 😄, to help with reviews.
In addition to this: