Skip to content

Commit

Permalink
ci(detox-ios): try removing xcode pin
Browse files Browse the repository at this point in the history
  • Loading branch information
thomas-pearson-mattr committed Dec 9, 2024
1 parent 4fea416 commit 21ade55
Showing 1 changed file with 8 additions and 23 deletions.
31 changes: 8 additions & 23 deletions .github/workflows/ci-detox-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,15 @@ jobs:
toolchain: 1.70.0
override: true

- name: Print versions
run: |
rustc --version
xcodebuild -version
- name: Xcode version
run: xcodebuild -version

- name: List Installed Xcode Versions
run: ls /Applications | grep Xcode

- name: Set Xcode Version
run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer
# Try without pinning xocode
# - name: Set Xcode Version
# run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer

- name: Verify Xcode Version
run: xcodebuild -version
Expand All @@ -52,12 +51,6 @@ jobs:
name: Detox iOS E2E Testing
needs: [libraries]
runs-on: macos-14
# strategy:
# matrix:
# runners: [[self-hosted, macos, general, detox-ios]]
# concurrency:
# group: ci-detox-ios-${{ matrix.runners }}-${{ github.head_ref || github.run_id }}
# cancel-in-progress: true
timeout-minutes: 120

defaults:
Expand All @@ -66,7 +59,7 @@ jobs:
shell: zsh -il {0} # load ~/.zshrc

env:
DEVELOPER_DIR: /Applications/Xcode_16.app/Contents/Developer
# DEVELOPER_DIR: /Applications/Xcode_16.app/Contents/Developer
NODE_OPTIONS: "--max-old-space-size=5120"
# Do not launch packager during CI build
RCT_NO_LAUNCH_PACKAGER: "true"
Expand All @@ -87,8 +80,8 @@ jobs:
name: ci-detox-ios-artifacts-libs-${{ github.sha }}
path: wrappers/react-native/ios/lib

- name: Set Xcode Version
run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer
#- name: Set Xcode Version
# run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer

- name: Inspect iOS Libraries
run: ls -R ios/lib
Expand All @@ -112,14 +105,6 @@ jobs:
run: |
xcrun simctl create "iPhone 11" com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-17-0
# - name: Setup iOS Simulator
# uses: futureware-tech/simulator-action@bfa03d93ec9de6dacb0c5553bbf8da8afc6c2ee9 #pin @v3
# with:
# model: "iPhone 11"
# os_version: =17.0 # https://github.com/futureware-tech/simulator-action/wiki
# shutdown_after_job: true
# erase_before_boot: true # change to true for temporary fix when some of the tests are failing

- name: Detox Build iOS Configuration
run: yarn detox:build:ios

Expand Down

0 comments on commit 21ade55

Please sign in to comment.