Skip to content

Commit

Permalink
ci(detox-ios): clean up try removing iphone 11 setup
Browse files Browse the repository at this point in the history
  • Loading branch information
thomas-pearson-mattr committed Dec 9, 2024
1 parent 21ade55 commit e1ed1bc
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions .github/workflows/ci-detox-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ jobs:
uses: actions-rs/toolchain@b2417cde72dcf67f306c0ae8e0828a81bf0b189f # [email protected]
with:
profile: minimal
# TODO: use the latest stable
# needed to pin otherwise getting a linker error as some symbols have been removed
# from the ios aarch64-apple-ios toolchain
# ld: Undefined symbols '___chkstk_darwin' referenced from 'libblst'
# https://github.com/mattrglobal/pairing_crypto/pull/231#discussion_r1875117128
toolchain: 1.70.0
override: true

Expand All @@ -29,10 +34,6 @@ jobs:
- name: List Installed Xcode Versions
run: ls /Applications | grep Xcode

# Try without pinning xocode
# - name: Set Xcode Version
# run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer

- name: Verify Xcode Version
run: xcodebuild -version

Expand All @@ -59,7 +60,6 @@ jobs:
shell: zsh -il {0} # load ~/.zshrc

env:
# DEVELOPER_DIR: /Applications/Xcode_16.app/Contents/Developer
NODE_OPTIONS: "--max-old-space-size=5120"
# Do not launch packager during CI build
RCT_NO_LAUNCH_PACKAGER: "true"
Expand All @@ -80,9 +80,6 @@ jobs:
name: ci-detox-ios-artifacts-libs-${{ github.sha }}
path: wrappers/react-native/ios/lib

#- name: Set Xcode Version
# run: sudo xcode-select -s /Applications/Xcode_16.app/Contents/Developer

- name: Inspect iOS Libraries
run: ls -R ios/lib

Expand All @@ -101,9 +98,10 @@ jobs:
- name: Print Simulators
run: applesimutils --list

- name: Install iPhone 11 Simulator
run: |
xcrun simctl create "iPhone 11" com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-17-0
# TODO: Lets look at this next and check if need it
# - name: Install iPhone 11 Simulator
# run: |
# xcrun simctl create "iPhone 11" com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-17-0

- name: Detox Build iOS Configuration
run: yarn detox:build:ios
Expand Down

0 comments on commit e1ed1bc

Please sign in to comment.