Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7524: Rename channels page needs animated GIFs for mobile app workflows #7525

Merged
merged 2 commits into from
Oct 31, 2024
Merged

DOC-7524: Rename channels page needs animated GIFs for mobile app workflows #7525

merged 2 commits into from
Oct 31, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 31, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Rename channels page

Ticket Link

Fixes #7524

  • This PR follows Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you.

@lindy65 lindy65 added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 31, 2024
@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA f33eda5

cwarnermm
cwarnermm approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rutam21!

@varghesejose2020
Copy link
Contributor

varghesejose2020 commented Oct 31, 2024 •
edited
Loading

@lindy65 please assign me for testing this PR

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

The changes are tested in the preview environment and they reflect properly.

  • The Rename channels page has now 5 workflow images for visual learners.

Please refer to the screenshots below as a confirmation.

Current Docs Page [Rename Channels]

Screenshot 2024-10-31 185923

Preview Environment Page

Step 1

Screenshot 2024-10-31 185953

Step 2

Screenshot 2024-10-31 190059

Step 3

Screenshot 2024-10-31 190114

Step 4

Screenshot 2024-10-31 190129

Step 5
Screenshot 2024-10-31 190144

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 31, 2024 •
edited
Loading

@lindy65 please assign me for testing this PR

Hi @varghesejose2020 - Rutam was already assigned this PR for testing here

@Rutam21 Rutam21 mentioned this pull request Oct 31, 2024
Merged
1 task
@cwarnermm cwarnermm added QA-done QA review is complete and removed QA-wanted labels Oct 31, 2024
@cwarnermm cwarnermm merged commit 457e3eb into mattermost:master Oct 31, 2024
4 checks passed
@Rutam21 Rutam21 deleted the DOC-7524 branch October 31, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees

@Rutam21 Rutam21

Labels
Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename channels page needs animated GIFs for mobile app workflows
5 participants
@Rutam21 @mattermost-build @varghesejose2020 @lindy65 @cwarnermm