Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-7526: Communicate a channel’s focus and scope page needs animated… #7527

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 31, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Communicate a channel’s focus and scope page

Ticket Link

Fixes #7526

  • This PR follows Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you.

@cwarnermm cwarnermm added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 31, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 260e1a7

@lindy65
Copy link
Contributor

lindy65 commented Oct 31, 2024

Assigned to you for testing @Rutam21 👍

@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 31, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 8bc3229

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 31, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA ecc004b

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 31, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 8c1a612

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm I got the bug. This PR uses the image files added in this PR: #7525. Hence, those image files are missing from this preview branch. This should resolve itself after we merge that PR and try building another preview.

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 31, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 8c1a612

@cwarnermm
Copy link
Member

Thanks, @Rutam21 for that heads-up! Splitting image files across PRs would definitely net poor results in previews. I've merged the related PR. Once published, I'll confirm it's working as expected, then come back to this PR. If previews still aren't working, I'll either pull the fork down locally OR may merge then fix.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm Points noted. I will keep this in mind while raising the next PRs. However, the preview still seems to be broken but the changes work after the merge. Please find a screenshot of the local docs build attached.

Screenshot 2024-11-01 022136

@cwarnermm
Copy link
Member

The shorter path through on this PR is to merge it and investigate/fix it in production. So that's what I'm going to do.

@cwarnermm cwarnermm merged commit d3abea5 into mattermost:master Nov 1, 2024
4 checks passed
@amyblais amyblais removed the 2: Editor Review Requires review by an editor label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate a channel’s focus and scope page needs animated GIFs for mobile app workflows
5 participants