crypto: encrypt, upload and share keys for room history #4864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
3 times, most recently
from
41d75d1 to
ea0b176
Compare
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
2 times, most recently
from
f93d4a6 to
3149616
Compare
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
4 times, most recently
from
211b9ad to
7cb525f
Compare
richvdh
commented
Apr 9, 2025
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
2 times, most recently
from
632e1b6 to
e963311
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4864 +/- ##
==========================================
+ Coverage 85.84% 85.95% +0.11%
==========================================
Files 323 324 +1
Lines 35515 35611 +96
==========================================
+ Hits 30487 30610 +123
+ Misses 5028 5001 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
3 times, most recently
from
6963c22 to
548cd49
Compare
|
I wish github would show when someone presses the "Start Review" button, I guess I could have also told you. Is there more coming, should I wait for things to calm down? |
|
oh, sorry. Occasionally we use an 👀 reaction on the PR to denote "I'm looking at this". I'm not planning any more work on this, though that was also the case this morning, and then things changed. Let me see what's wrong with the CI, then I'll leave it alone. |
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
5b6962b to
000b630
Compare
poljar
requested changes
Apr 14, 2025
crates/matrix-sdk-crypto/src/session_manager/group_sessions/mod.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-crypto/src/session_manager/group_sessions/mod.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-crypto/src/session_manager/group_sessions/mod.rs
Outdated
Show resolved
Hide resolved
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
7ba8967 to
2420934
Compare
The next step in our work on sharing encrypted room history. Add a method to `matrix_sdk::room::Room` which will upload an encrypted key bundle.
For each device belonging to the user, encrypt and send to-device messages containing the bundle data
This is only a partial test, since we haven't yet implemented the receiver side of the history-sharing messages.
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
a600c49 to
80db096
Compare
Signed-off-by: Richard van der Hoff <[email protected]>
Signed-off-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step of our plan to share room history (element-hq/element-meta#39). This PR adds the functionality to:
Fixes: #4505