Skip to content

crypto: store received room key bundle data information #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 24, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 14, 2025

Add hooks to the memory store and sqlite store to stash the information about room key data.

Fixes #4512

@richvdh richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch 3 times, most recently from 00a01ec to cd6d8af Compare April 16, 2025 14:42
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 52.54237% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (1554e05) to head (a3cb1cd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-sqlite/src/crypto_store.rs 24.13% 22 Missing ⚠️
crates/matrix-sdk-crypto/src/store/memorystore.rs 66.66% 3 Missing ⚠️
crates/matrix-sdk-crypto/src/machine/mod.rs 81.81% 2 Missing ⚠️
crates/matrix-sdk-crypto/src/store/traits.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4932      +/-   ##
==========================================
- Coverage   85.98%   85.91%   -0.07%     
==========================================
  Files         325      325              
  Lines       35654    35690      +36     
==========================================
+ Hits        30657    30663       +6     
- Misses       4997     5027      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@richvdh richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 7fa98b0 to 8131301 Compare April 16, 2025 15:57
@richvdh richvdh marked this pull request as ready for review April 17, 2025 07:51
@richvdh richvdh requested review from a team as code owners April 17, 2025 07:51
@richvdh richvdh requested review from poljar and removed request for a team April 17, 2025 07:51
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a couple of nits.

@richvdh richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 974a60e to 131022b Compare April 23, 2025 15:30
@richvdh richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 131022b to 85e0626 Compare April 23, 2025 19:00
@richvdh richvdh enabled auto-merge April 23, 2025 19:03
@richvdh richvdh disabled auto-merge April 24, 2025 11:07
@richvdh richvdh enabled auto-merge April 24, 2025 11:09
@richvdh richvdh merged commit 468e7c3 into main Apr 24, 2025
41 of 42 checks passed
@richvdh richvdh deleted the rav/history_sharing/save_key_bundle_data branch April 24, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypted history sharing: receive to-device messages and stash data somewhere
2 participants