crypto: Save private identity in the MemoryStore #3222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/store-trackedusers-in-memorystore
branch
from
9e4eda3 to
1cdf6c8
Compare
andybalaam
force-pushed
the
andybalaam/store-private-identity-in-memorystore
branch
from
241af7e to
3342f11
Compare
andybalaam
force-pushed
the
andybalaam/store-trackedusers-in-memorystore
branch
2 times, most recently
from
af83204 to
099c855
Compare
Base automatically changed from
andybalaam/store-trackedusers-in-memorystore
to
main
March 19, 2024 15:29
andybalaam
force-pushed
the
andybalaam/store-private-identity-in-memorystore
branch
from
3342f11 to
9caec95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3222 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 236 236
Lines 24443 24447 +4
=======================================
+ Hits 20450 20454 +4
Misses 3993 3993 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I am trying to get
MemoryStoreto pass thecryptostore_integration_tests, I need this store to hold on to the private identity when previously it didn't both.Applies on top of #3221
Part of my work on element-hq/element-web#26892