crypto: Refactor integration tests in preparation for them running against MemoryStore #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/store-private-identity-in-memorystore
branch
from
241af7e to
3342f11
Compare
andybalaam
force-pushed
the
andybalaam/adjust-integration-tests
branch
from
dd6dff6 to
bfd90ee
Compare
andybalaam
force-pushed
the
andybalaam/store-private-identity-in-memorystore
branch
from
3342f11 to
9caec95
Compare
Base automatically changed from
andybalaam/store-private-identity-in-memorystore
to
main
March 20, 2024 09:09
…ainst MemoryStore A couple of small changes that allow us to drop locks that would otherwise persist when running the tests over the MemoryStore, and some documentation comments for assertions to make it easier to spot which assertion failed, even though we are inside a macro.
andybalaam
force-pushed
the
andybalaam/adjust-integration-tests
branch
from
bfd90ee to
40d96db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3223 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 236 236
Lines 24474 24474
=======================================
Hits 20477 20477
Misses 3997 3997 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small changes that allow us to drop locks that would otherwise persist when running the tests over the MemoryStore, and some documentation comments for assertions to make it easier to spot which assertion failed, even though we are inside a macro.
Applies on top of #3222
Part of my work on element-hq/element-web#26892