This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix room list sorting woes #4164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
suggested changes
Mar 3, 2020
| @@ -527,20 +544,19 @@ class RoomListStore extends Store { | |||
| room, category, key, this._state.lists[key], listsClone[key], lastTimestamp); | |||
|
|
|||
| if (!pushedEntry) { | |||
| // This should rarely happen: _slotRoomIntoList has several checks which attempt | |||
| // XXX: This should rarely happen: _slotRoomIntoList has several checks which attempt | |||
There was a problem hiding this comment.
It's not an XXX, it's an actual feature.
There was a problem hiding this comment.
we also probably want to keep the "insert at the top to get a bug report" bits, as generating the initial room lists masks the problem.
| // We insert our own record as needed, so don't let the old one through. | ||
| if (entry.room.roomId === room.roomId) { | ||
| continue; | ||
| if (existingIndex === null && entry.room.roomId === room.roomId) { |
There was a problem hiding this comment.
This is probably where your duplication is happening: multiple copies of a room can be sent through this function, which is why it does an early filter rather than selective removal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves to regenerating the lists whenever _slotRoomIntoList breaks. Better solution would be to apply something along the lines of element-hq/element-web#11743 but this needs a product meeting on exactly what we want out of the room list in terms of behaviour, "sticky room" I'm looking at you.
Fixes element-hq/element-web#12588