Skip to content

Room list does not reorder on new messages #12588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikjohnston opened this issue Mar 2, 2020 · 8 comments · Fixed by matrix-org/matrix-react-sdk#4175
Closed

Room list does not reorder on new messages #12588

erikjohnston opened this issue Mar 2, 2020 · 8 comments · Fixed by matrix-org/matrix-react-sdk#4175

Comments

@erikjohnston
Copy link
Member

When getting a new message the room list doesn't reorder to bubble the room to the top. This happens for both DMs and rooms. The lists don't appear to ever reorder, even if I go to different rooms, send messages, change windows, etc.

Platform:

  • Browser: Chrome
  • OS: Ubuntu
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Mar 2, 2020

What options do you have for your room list sorting? (top two toggles in Settings > Preferences)

@erikjohnston
Copy link
Member Author

Both are off ("Order rooms by name" and "Show rooms with unread notifications first")

@tulir
Copy link
Contributor

tulir commented Mar 2, 2020

I guess "Show rooms with unread notifications first" is the old behavior and it just needs to be enabled by default?

@erikjohnston
Copy link
Member Author

I guess "Show rooms with unread notifications first" is the old behavior and it just needs to be enabled by default?

That orders based on if there's an unread message or notification and reorders the list when you've read the room (so it drops down the list). The old behaviour was to order by last message send time only.

@turt2live
Copy link
Member

There's a couple levels of old behaviour: we turned on the "unread notifications first" ordering by default for people, but I believe @erikjohnston turned it off after we did that to make the thing just ordered by recents.

Because of this, the room list sorting might be confused and think that the settings mean something different depending on where they're read.

@erikjohnston
Copy link
Member Author

So I should be enabling Show rooms with unread notifications first to get to default behaviour?

(FWIW the room list not updating is surprisingly annoying since I end up not realising there are new events in rooms)

@jryans
Copy link
Collaborator

jryans commented Mar 3, 2020

I believe the core problem here is that adding alpha sort introduced a regression, which matrix-org/matrix-react-sdk#4164 should soon fix. @erikjohnston, you should not need to change anything to preserve the same behaviour you'd had for a while (once the regression is fixed).

@turt2live
Copy link
Member

@erikjohnston please make loud noises in riot-web internal if this isn't fixed after refreshing develop.

t3chguy added a commit that referenced this issue Oct 17, 2024
* Dummy PR to Netlify matrix-org/matrix-js-sdk#4233

Signed-off-by: Michael Telatynski <[email protected]>

* Remove unused state field

Signed-off-by: Michael Telatynski <[email protected]>

* Discard changes to .prettierignore

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment