Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2090

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ You have the `App` with the `MoviesList` and `NewMovie` form containing ready
to use `TextField` components. Learn how it works and implement an ability to
add movies from [IMDB](https://www.imdb.com/).

If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`
If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`

> Here is [the demo page](https://mate-academy.github.io/react_movies-list-add-form/)

Expand All @@ -30,4 +30,4 @@ const pattern = /^((([A-Za-z]{3,9}:(?:\/\/)?)(?:[-;:&=+$,\w]+@)?[A-Za-z0-9.-]+|(
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_movies-list-add-form/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://pivkopa.github.io/react_movies-list-add-form/) and add it to the PR description.
10 changes: 8 additions & 2 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
import { useState } from 'react';
import './App.scss';
import { MoviesList } from './components/MoviesList';
import { NewMovie } from './components/NewMovie';
import moviesFromServer from './api/movies.json';

export const App = () => {
const [prepMovies, setPrepMovies] = useState(moviesFromServer);

return (
<div className="page">
<div className="page-content">
<MoviesList movies={moviesFromServer} />
<MoviesList movies={prepMovies} />
</div>
<div className="sidebar">
<NewMovie /* onAdd={(movie) => {}} */ />
<NewMovie onAdd={(movie) => {
setPrepMovies(currentMovies => [...currentMovies, movie]);
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a separate handler for this

/>
</div>
</div>
);
Expand Down
119 changes: 109 additions & 10 deletions src/components/NewMovie/NewMovie.tsx
Original file line number Diff line number Diff line change
@@ -1,56 +1,155 @@
import { useState } from 'react';
import React, { useState } from 'react';
import { TextField } from '../TextField';
import { Movie } from '../../types/Movie';

export const NewMovie = () => {
export interface NewMovieProps {
onAdd: (movie: Movie) => void;
}

export const NewMovie: React.FC<NewMovieProps> = ({ onAdd }) => {
// Increase the count after successful form submission
// to reset touched status of all the `Field`s
const [count] = useState(0);
const defaultMovie = {
title: '',
description: '',
imgUrl: '',
imdbUrl: '',
imdbId: '',
};

const [count, setCount] = useState(0);
const [newMovie, setNewMovie] = useState(defaultMovie);

const ableToAddMovie = newMovie.title.trim()
&& newMovie.imgUrl.trim() && newMovie.imdbUrl.trim()
&& newMovie.imdbId.trim();

const createMovie = (): Movie => {
return {
title: newMovie.title,
description: newMovie.description,
imgUrl: newMovie.imgUrl,
imdbUrl: newMovie.imdbUrl,
imdbId: newMovie.imdbId,
};
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you need this function?

const submitAddMovie = () => {
const movie = createMovie();

setNewMovie(currentMovie => {
return {
...currentMovie,
title: '',
description: '',
imgUrl: '',
imdbUrl: '',
imdbId: '',
};
});

setCount((currentCount) => currentCount + 1);

onAdd(movie);
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can write more simple

const submitAddMovie  = (event: React.FormEvent<HTMLFormElement>) => {
    event.preventDefault();
    
    onAdd(newMovie);
    setNewMovie(defaultMovie);
    setCount((currentCount) => currentCount + 1);
  };

return (
<form className="NewMovie" key={count}>
<form
className="NewMovie"
key={count}
onSubmit={event => {
event.preventDefault();
submitAddMovie();
}}
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should move your "event.preventDefault();" to your function submitAddMovie.
And put here only link to your function

Suggested change
onSubmit={event => {
event.preventDefault();
submitAddMovie();
}}
onSubmit={submitAddMovie}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here write

 onSubmit={submitAddMovie}

<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value=""
onChange={() => {}}
value={newMovie.title}
onChange={(event) => {
setNewMovie(currentMovie => {
return {
...currentMovie,
title: event,
};
});
}}
required
/>

<TextField
name="description"
label="Description"
value=""
value={newMovie.description}
onChange={(event) => {
setNewMovie(currentMovie => {
return {
...currentMovie,
description: event,
};
});
}}
/>

<TextField
name="imgUrl"
label="Image URL"
value=""
value={newMovie.imgUrl}
onChange={(event) => {
setNewMovie(currentMovie => {
return {
...currentMovie,
imgUrl: event,
};
});
}}
required
/>

<TextField
name="imdbUrl"
label="Imdb URL"
value=""
value={newMovie.imdbUrl}
onChange={(event) => {
setNewMovie(currentMovie => {
return {
...currentMovie,
imdbUrl: event,
};
});
}}
required
/>

<TextField
name="imdbId"
label="Imdb ID"
value=""
value={newMovie.imdbId}
onChange={(event) => {
setNewMovie(currentMovie => {
return {
...currentMovie,
imdbId: event,
};
});
}}
required
/>

<div className="field is-grouped">
<div className="control">

<button
type="submit"
data-cy="submit-button"
className="button is-link"
disabled={!ableToAddMovie}
>
Add
</button>

</div>
</div>
</form>
Expand Down
Loading