solution #2090
Open
solution #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostrubitskii
suggested changes
Jan 16, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); | ||
|
|
||
| // const [hasReset, setHasReset] = useState(false); |
src/components/NewMovie/NewMovie.tsx
Outdated
|
|
||
| // const [hasReset, setHasReset] = useState(false); | ||
|
|
||
| const able = titleValue.trim() |
There was a problem hiding this comment.
I think you need to rename your variable, for better understanding
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
54
to
57
| onSubmit={event => { | ||
| event.preventDefault(); | ||
| submitAddMovie(); | ||
| }} |
There was a problem hiding this comment.
Maybe you should move your "event.preventDefault();" to your function submitAddMovie.
And put here only link to your function
Suggested change
| onSubmit={event => { | |
| event.preventDefault(); | |
| submitAddMovie(); | |
| }} | |
| onSubmit={submitAddMovie} |
olya-shyian
suggested changes
Jan 16, 2024
| <NewMovie /* onAdd={(movie) => {}} */ /> | ||
| <NewMovie onAdd={(movie) => { | ||
| setPrepMovies(currentMovies => [...currentMovies, movie]); | ||
| }} |
There was a problem hiding this comment.
please create a separate handler for this
src/components/NewMovie/NewMovie.tsx
Outdated
| const [description, setDescription] = useState(''); | ||
| const [imgUrlValue, setImgUrl] = useState(''); | ||
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); |
There was a problem hiding this comment.
instead of creating a lot of states, use just one
const defaultMovie = {
title: '',
description: '',
imgUrl: '',
imdbUrl: '',
imdbId: '',
};
const [count, setCount] = useState(0);
const [newMovie, setNewMovie] = useState(defaultMovie);
olya-shyian
suggested changes
Jan 18, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
| imdbUrl: newMovie.imdbUrl, | ||
| imdbId: newMovie.imdbId, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
are you sure you need this function?
| setCount((currentCount) => currentCount + 1); | ||
|
|
||
| onAdd(movie); | ||
| }; |
There was a problem hiding this comment.
you can write more simple
const submitAddMovie = (event: React.FormEvent<HTMLFormElement>) => {
event.preventDefault();
onAdd(newMovie);
setNewMovie(defaultMovie);
setCount((currentCount) => currentCount + 1);
};
src/components/NewMovie/NewMovie.tsx
Outdated
| onSubmit={event => { | ||
| event.preventDefault(); | ||
| submitAddMovie(); | ||
| }} |
There was a problem hiding this comment.
and here write
onSubmit={submitAddMovie}
YegorKorenkov
suggested changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK