Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1808

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions src/herbivoresAndCarnivores.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,41 @@
'use strict';

class Animal {
// write your code here
constructor(name, health = 100) {
this.name = name;
this.health = health;

Animal.alive.push(this);
}

static filterDeadAnimals() {
this.alive = this.alive.filter((animal) => animal.health > 0);
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#952
That's why you have failed tests

Suggested change
Animal.alive = [];

Animal.alive = [];

class Herbivore extends Animal {
// write your code here
constructor(name) {
super(name);
this.hidden = false;
}

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(animal) {
if (animal instanceof Herbivore && !animal.hidden) {
animal.health -= 50;

if (animal.health <= 0) {
Animal.filterDeadAnimals();
}
Comment on lines +31 to +36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should avoid nested if statements - as it makes your code more difficult to read

}
}
}

module.exports = {
Expand Down