Solution #1808
Open
Solution #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33Orange
suggested changes
May 30, 2023
src/herbivoresAndCarnivores.js
Outdated
| @@ -1,15 +1,46 @@ | |||
| 'use strict'; | |||
|
|
|||
| class Animal { | |||
| // write your code here | |||
| static alive = []; | |||
| if (index !== -1) { | ||
| Animal.alive.splice(index, 1); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
#952
That's why you have failed tests
Suggested change
| Animal.alive = []; |
src/herbivoresAndCarnivores.js
Outdated
Comment on lines
12
to
17
| static removeFromAlive(animal) { | ||
| const index = Animal.alive.indexOf(animal); | ||
| if (index !== -1) { | ||
| Animal.alive.splice(index, 1); | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use only 1 filter instead, which will clear the array from animals with health less than or equal to 0
src/herbivoresAndCarnivores.js
Outdated
| } | ||
|
|
||
| bite(animal) { | ||
| if (!(animal instanceof Carnivore) && !animal.hidden) { |
There was a problem hiding this comment.
Just check if animal instanceof Herbivore instead.
Suggested change
| if (!(animal instanceof Carnivore) && !animal.hidden) { | |
| if (animal instanceof Herbivore && !animal.hidden) { |
silchyn
suggested changes
Jun 12, 2023
src/herbivoresAndCarnivores.js
Outdated
Comment on lines
10
to
12
| static removeFromAlive(animal) { | ||
| Animal.alive = Animal.alive.filter((a) => a.health > 0); | ||
| } |
silchyn
suggested changes
Jun 23, 2023
src/herbivoresAndCarnivores.js
Outdated
Comment on lines
5
to
7
| this.name = name; | ||
| this.health = health; | ||
| Animal.alive.push(this); |
There was a problem hiding this comment.
Suggested change
| this.name = name; | |
| this.health = health; | |
| Animal.alive.push(this); | |
| this.name = name; | |
| this.health = health; | |
| Animal.alive.push(this); |
src/herbivoresAndCarnivores.js
Outdated
| Animal.alive.push(this); | ||
| } | ||
|
|
||
| static removeFromAlive() { |
There was a problem hiding this comment.
Suggested change
| static removeFromAlive() { | |
| static filterDeadAnimals() { |
src/herbivoresAndCarnivores.js
Outdated
| animal.health -= 50; | ||
|
|
||
| if (animal.health <= 0) { | ||
| Animal.removeFromAlive(animal); |
There was a problem hiding this comment.
This function doesn't take any parameters
naziamoff
approved these changes
Jun 29, 2023
Comment on lines
+31
to
+36
| if (animal instanceof Herbivore && !animal.hidden) { | ||
| animal.health -= 50; | ||
|
|
||
| if (animal.health <= 0) { | ||
| Animal.filterDeadAnimals(); | ||
| } |
There was a problem hiding this comment.
you should avoid nested if statements - as it makes your code more difficult to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.