Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning of all object id and some tests #4226

Merged
merged 16 commits into from
Jul 21, 2023
Merged

Add versioning of all object id and some tests #4226

merged 16 commits into from
Jul 21, 2023

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Jul 6, 2023 •
edited
Loading

Ids to versions to :

  • OperationID
  • BlockID
  • EndorsementID

Fix #4196

@AurelienFT AurelienFT force-pushed the add_version_to_all_elements branch from dca6ef2 to 5de9db5 Compare July 7, 2023 13:05
@AurelienFT AurelienFT marked this pull request as ready for review July 7, 2023 13:12
@AurelienFT AurelienFT requested review from Eitu33 and damip July 7, 2023 13:12
@AurelienFT
Copy link
Contributor Author

@Eitu33 after your review this week can you test in labnet please

@sydhds sydhds linked an issue Jul 10, 2023 that may be closed by this pull request
Versioni info in Address, BlockId, OperationId & co #4196
Closed
6 tasks
@Eitu33
Copy link
Contributor

Eitu33 commented Jul 12, 2023

This PR has been tested and works properly (in a labnet environment)

@sydhds
Copy link
Contributor

sydhds commented Jul 13, 2023

This PR has been tested and works properly (in a labnet environment)

Would this be a good time to remove from_bytes_without_version (as described here: #3631) ?

@sydhds sydhds mentioned this pull request Jul 13, 2023
Open
18 tasks
@AurelienFT
Copy link
Contributor Author

from_bytes_without_version

What's the motivation for this ?

@AurelienFT AurelienFT requested a review from Eitu33 July 17, 2023 12:26
@sydhds
Copy link
Contributor

sydhds commented Jul 18, 2023

from_bytes_without_version

What's the motivation for this ?

I'm afraid I cannot help as I do not remember it. @Eitu33 can help

@Eitu33
Copy link
Contributor

Eitu33 commented Jul 19, 2023

I'm afraid I cannot help as I do not remember it. @Eitu33 can help

Checking if we can remove this

Eitu33
Eitu33 reviewed Jul 19, 2023
View reviewed changes
massa-models/src/operation.rs Show resolved Hide resolved
massa-models/src/block_id.rs Show resolved Hide resolved
massa-models/src/endorsement.rs Outdated Show resolved Hide resolved
massa-models/src/endorsement.rs Show resolved Hide resolved
@AurelienFT AurelienFT requested a review from Eitu33 July 19, 2023 15:11
@AurelienFT AurelienFT merged commit ff9a431 into testnet_25 Jul 21, 2023
10 checks passed
@AurelienFT AurelienFT deleted the add_version_to_all_elements branch October 23, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 approved these changes

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioni info in Address, BlockId, OperationId & co
3 participants
@AurelienFT @Eitu33 @sydhds