Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioni info in Address, BlockId, OperationId & co #4196

Closed
6 tasks done
sydhds opened this issue Jul 3, 2023 · 1 comment · Fixed by #4226
Closed
6 tasks done

Versioni info in Address, BlockId, OperationId & co #4196

sydhds opened this issue Jul 3, 2023 · 1 comment · Fixed by #4226
Assignees
@AurelienFT
Labels
p1

Comments

@sydhds
Copy link
Contributor

sydhds commented Jul 3, 2023 •
edited by AurelienFT
Loading

  • BlockId (and all XXId struct) should be versioned. Ensure that the binary ser/deser & text ser/deser are homogeneous regarding to this.

  • Check again Address & Keypair, it seems they are some issue with binary ser/deser (regarding the Version) but looks ok on the text side:

  • Check "impl Serializer for AddressSerializer" versus "to_prefixed_bytes(self)"

  • Check that the trait Preshashed is ok with those modification: the prehash might only use the part without version?

  • Check the consequence for OperationIdPrefix in the protocol

  • For Address, ensure that the thread computation is done without taking into account the version number (maybe add a unit test for that)?
@AurelienFT AurelienFT added the p1 label Jul 3, 2023
@AurelienFT AurelienFT self-assigned this Jul 3, 2023
@AurelienFT
Copy link
Contributor

AurelienFT commented Jul 3, 2023 •
edited
Loading

Check again Address & Keypair, it seems they are some issue with binary ser/deser (regarding the Version)

Can you be more precise ? we used it this month without problems

@AurelienFT AurelienFT removed their assignment Jul 4, 2023
@sydhds sydhds mentioned this issue Jul 4, 2023
Open
18 tasks
@AurelienFT AurelienFT self-assigned this Jul 6, 2023
@AurelienFT AurelienFT mentioned this issue Jul 6, 2023
Merged
3 tasks
@sydhds sydhds linked a pull request Jul 10, 2023 that will close this issue
Add versioning of all object id and some tests #4226
Merged
3 tasks
@sydhds sydhds closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add versioning of all object id and some tests massalabs/massa
2 participants
@sydhds @AurelienFT