Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default mail if nothing new since last newsletter #12
Default mail if nothing new since last newsletter #12
Changes from 3 commits
e35e042
73de00e
5e28886
e848b3e
67cfec4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I'm afraid the way to get the publication date of the article is a bit random. For example, targeting the HTML element to hope to find the publication date with
.publication-date, #pub-date
is really specific and will only work for a few pages!How to be sure that there is a publication date in the page and how to be sure to get the right one if there are several dates in the page?
IMO we can find a better way to handle this feature (using the database for instance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment it is the only way I found to find the date. The original scraper might mistake a date in the text as the publication date.
It only fetches the fields likely to have the publication date, and if multiple are found, it takes the most recent one.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.