Default mail if nothing new since last newsletter #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
requested changes
Feb 5, 2025
| max: 5, | ||
| minimumDate : new Date('2025-02-01'), |
There was a problem hiding this comment.
nit-pick:
Suggested change
| minimumDate : new Date('2025-02-01'), | |
| minDate : new Date('2025-02-01'), |
| }; | ||
|
|
||
| async function scrapeDate($: cheerio.CheerioAPI) { | ||
| // Extract the latest dazte of publication |
There was a problem hiding this comment.
Suggested change
| // Extract the latest dazte of publication | |
| // Extract the latest date of publication |
| @@ -15,5 +16,77 @@ export const scrape = async ({ | |||
| const $ = cheerio.load(await response.text()); | |||
| const dom = new JSDOM($.html()); | |||
| const article = new Readability(dom.window.document).parse(); | |||
| return article?.textContent.substring(0, maxContentSize); | |||
| const publicationDate = await scrapeDate($); | |||
There was a problem hiding this comment.
thought: I'm afraid the way to get the publication date of the article is a bit random. For example, targeting the HTML element to hope to find the publication date with .publication-date, #pub-date is really specific and will only work for a few pages!
How to be sure that there is a publication date in the page and how to be sure to get the right one if there are several dates in the page?
IMO we can find a better way to handle this feature (using the database for instance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The user should receive an email specifying there are no news this time.
Solution
The agent checks for the date of the different piece of news and filter only those published since the last newsletter.
How To Test
Go to newsletterFormat.ts and modify the links, interests or minimumDate of the articles.