chore: enable some more lints #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeb
reviewed
Aug 25, 2024
| @@ -72,8 +72,8 @@ pub struct GitDependency { | |||
| pub rev: Option<String>, | |||
| } | |||
|
|
|||
| impl core::fmt::Display for GitDependency { | |||
There was a problem hiding this comment.
Any reason for changing core::fmt to std::fmt? The latter is a re-export
There was a problem hiding this comment.
I prefer using std when possible, and core/alloc when no_std is enabled
Yes! Happy to see some more lints, I activated them on my refactor branch too. I'm rewriting all the tests at the moment because they are way too slow and mutate some checked files of the repo which is annoying. A lot of tests are run serially too which is not great. Finally, some tests which should not be async are marked async which is also suboptimal. |
beeb
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are copied from Foundry. I've not enabled them all, even if mostly auto-fixable, to not be too invasive because as I understand you're working on a big refactor for 0.4.0.