chore: enable some more lints (#160)

Cargo.toml

@@ -12,6 +12,25 @@ readme = "./README.md"
 repository = "https://github.com/mario-eth/soldeer"
 version = "0.3.0"
 
+[lints]
+workspace = true
+
+[workspace.lints.clippy]
+dbg-macro = "warn"
+manual-string-new = "warn"
+# uninlined-format-args = "warn"
+# use-self = "warn"
+redundant-clone = "warn"
+
+[workspace.lints.rust]
+rust-2018-idioms = "warn"
+# unreachable-pub = "warn"
+unused-must-use = "warn"
+redundant-lifetimes = "warn"
+
+[workspace.lints.rustdoc]
+all = "warn"
+
 [dependencies]
 chrono = { version = "0.4.38", default-features = false, features = [
     "std",

src/config.rs

@@ -5,7 +5,7 @@ use crate::{
 };
 use serde::{Deserialize, Serialize};
 use std::{
-    env,
+    env, fmt,
     fs::{self, remove_dir_all, remove_file, File},
     io::{self, Write},
     path::{Path, PathBuf},
@@ -72,8 +72,8 @@ pub struct GitDependency {
     pub rev: Option<String>,
 }
 
-impl core::fmt::Display for GitDependency {
-    fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
+impl fmt::Display for GitDependency {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}~{}", self.name, self.version)
     }
 }
@@ -86,8 +86,8 @@ pub struct HttpDependency {
     pub checksum: Option<String>,
 }
 
-impl core::fmt::Display for HttpDependency {
-    fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
+impl fmt::Display for HttpDependency {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}~{}", self.name, self.version)
     }
 }
@@ -208,8 +208,8 @@ impl Dependency {
     }
 }
 
-impl core::fmt::Display for Dependency {
-    fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
+impl fmt::Display for Dependency {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
             Dependency::Http(dep) => write!(f, "{}", dep),
             Dependency::Git(dep) => write!(f, "{}", dep),
@@ -352,7 +352,7 @@ pub async fn remappings_txt(
     }
     let contents = match remappings_path.exists() {
         true => read_file_to_string(&remappings_path),
-        false => "".to_string(),
+        false => String::new(),
     };
     let existing_remappings = contents.lines().filter_map(|r| r.split_once('=')).collect();
 
@@ -516,27 +516,17 @@ fn parse_dependency(name: impl Into<String>, value: &Item) -> Result<Dependency>
                 }
                 None => None,
             };
-            return Ok(Dependency::Git(GitDependency {
-                name: name.to_string(),
-                git: git.to_string(),
-                version,
-                rev,
-            }));
+            return Ok(Dependency::Git(GitDependency { name, git: git.to_string(), version, rev }));
         }
         None => {}
     }
 
     // we should have a HTTP dependency
     match table.get("url").map(|v| v.as_str()) {
         Some(None) => Err(ConfigError::InvalidField { field: "url".to_string(), dep: name }),
-        None => Ok(Dependency::Http(HttpDependency {
-            name: name.to_string(),
-            version,
-            url: None,
-            checksum: None,
-        })),
+        None => Ok(Dependency::Http(HttpDependency { name, version, url: None, checksum: None })),
         Some(Some(url)) => Ok(Dependency::Http(HttpDependency {
-            name: name.to_string(),
+            name,
             version,
             url: Some(url.to_string()),
             checksum: None,

src/lib.rs

@@ -1,4 +1,9 @@
+//! # soldeer
+//!
+//! Solidity package manager.
+
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
+
 use crate::{
     auth::login,
     config::{delete_config, read_config_deps, remappings_txt, Dependency},

src/lock.rs

@@ -362,7 +362,7 @@ integrity = "deadbeef"
             url: Some( "https://github.com/mario-eth/soldeer-versions/raw/main/all_versions/@openzeppelin-contracts~2.5.0.zip".to_string()),
             checksum: Some("5019418b1e9128185398870f77a42e51d624c44315bb1572e7545be51d707016".to_string())
         });
-        let dependencies = vec![dependency.clone(), dependency2.clone()];
+        let dependencies = vec![dependency.clone(), dependency2];
         write_lock(
             &dependencies,
             &[Some("deadbeef".into()), Some("deadbeef".into())],

tests/ci/foundry.rs

@@ -13,8 +13,6 @@ use std::{
     process::Command,
 };
 
-extern crate soldeer;
-
 #[test]
 #[serial]
 fn soldeer_install_valid_dependency() {