Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MantisBT 2.6.0 (Resolving the inline script problem) #6

Merged
merged 6 commits into from
Nov 28, 2017
Merged

Update to MantisBT 2.6.0 (Resolving the inline script problem) #6

merged 6 commits into from
Nov 28, 2017

Conversation

mrkpatchaa
Copy link
Contributor

I've update the plugin to resolve the inline script problem.
The core modification is that all javascript code is in a separate js file. The configuration is injected via meta tags.
I've also :

  • Update google api php client to latest version
  • Added french translation
  • Made some cleanup

@luzpaz
Copy link
Contributor

luzpaz commented Nov 3, 2017

@kkremitzki perhaps we can test this on FC ?

@dam326
Copy link

dam326 commented Nov 8, 2017

don't work with 2.8.0 .
have you planned an update soon ?

on login_page.php i dont have "Sign in with google"

@mrkpatchaa
Copy link
Contributor Author

Hi @dam326 I didn't test it with 2.8 version since it was not yet published when I pushed this update. Can you debug and tell which error you have ?

@luzpaz
Copy link
Contributor

luzpaz commented Nov 8, 2017

@rmkpatchaa take a look at #3 (comment)

@mrkpatchaa
Copy link
Contributor Author

@luzpaz ok. Unfortunately I don't have time for now to do it. I'll check later if I can. It should be good if someone here has a little time to dig into it.

@mrkpatchaa
Copy link
Contributor Author

@luzpaz I think there is a misunderstanding... Dependencies for plugins given as examples are MantisBT 2.3+.
My fix works for MantisBT 2.6.
So if there is a problem with 2.8 release, something might have changed since then.

@xezpeleta
Copy link
Contributor

xezpeleta commented Nov 24, 2017

Hi! I've applied the patch and it works like a charm with Mantis 2.8. Can anybody merge this PR ?

@dam326 have you configured the plugin with the correct credentials?

Thanks @rmkpatchaa !! Good work!!

@luzpaz
Copy link
Contributor

luzpaz commented Nov 24, 2017

I haven't tested yet. I need to ask @kkremitzki if he can install this plugin, though I know he's busy these days.
I wonder if @dregad is interested in this ?

@dregad
Copy link
Member

dregad commented Nov 24, 2017

I wonder if @dregad is interested in this ?

Why should I be ?

.gitignore Outdated
*.iml
out
gen### Example user template template
### Example user template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmkpatchaa Looks like something went wrong with your .gitignore changes, the same files are excluded twice and the comments are duplicated as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited :)

@luzpaz
Copy link
Contributor

luzpaz commented Nov 24, 2017

@dregad Well I thought it would be a nice feature to be able to tout for Mantis, especially that most of the popular bugtrackers provide this feature not just for GitHub but other bugtrackers as well.

@dregad
Copy link
Member

dregad commented Nov 24, 2017

So you mean integrating the plugin as a standard authentication method in the core ? If yes, this is what @vboctor's comment #3 (comment) is about.

@dam326
Copy link

dam326 commented Nov 27, 2017

@xezpeleta : i test it again and it works with mantis 2.8 ! i don't understand why it didn't work my first time.

@luzpaz luzpaz mentioned this pull request Nov 27, 2017
@luzpaz
Copy link
Contributor

luzpaz commented Nov 27, 2017

What's blocking this from merge ?

@alleen alleen merged commit 0e40b22 into mantisbt-plugins:master Nov 28, 2017
@luzpaz luzpaz mentioned this pull request Nov 28, 2017
@comxd
Copy link

comxd commented Jan 31, 2018

In my case (MantisBT 2.10) the htaccess located at /plugins folder prevent access to the plugin.js file located at /plugins/GoogleOauth/pages/assets/js/plugin.js

luzpaz added a commit to luzpaz/GoogleOauth that referenced this pull request Mar 3, 2018
alleen added a commit that referenced this pull request Mar 4, 2018
README: supports mantisbt >= v2.6  based on #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants