Fix ast deprecation warnings up to Python 3.13. #434
Merged
+124
−84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't so trivial after all ...
The changes have less specific types than before, as all of
ast.Num
,ast.Str
andast.Index
becomeast.Constant
. This has been the case since Python 3.9 and it worked fine. I added additionalisinstance
checks. Not sure those are required or even harmful for some usecases.Node.lineno
can't beNone
, but also can't be omitted. I addedast.copy_location
andast.fix_missing_locations
calls, but I'm not sure they do the desired thing at each place, as I don't fully understand what the places they are used are actually doing.For the
visit_FunctionDef
transformer I couldn't find a more elegant solution to fix mypy. Thetype_params
doesn't seem to be required, as the tests work without, but the type definition (and docs) seems to say otherwise.