Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fixups #435

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Remove unnecessary fixups #435

merged 1 commit into from
Dec 22, 2024

Conversation

malthe
Copy link
Owner

@malthe malthe commented Dec 22, 2024

Some refactoring after changes in #434.

The specific lineno is not important here and because mypy wants an integer (and not None or simply omitting the parameter), we'll just provide an arbitrary value, e.g. -1.

The requirement of having a lineno is used some places in the Python standard library's AST module, concerned with type hints.

@coveralls
Copy link

coveralls commented Dec 22, 2024

Pull Request Test Coverage Report for Build 12455819633

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 92.331%

Totals Coverage Status
Change from base Build 12454306269: -0.009%
Covered Lines: 3915
Relevant Lines: 4166

💛 - Coveralls

@malthe malthe merged commit e194d10 into master Dec 22, 2024
29 checks passed
@malthe malthe deleted the fix-lineno branch December 22, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants