Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version to 20 #6363

Closed
wants to merge 1 commit into from
Closed

chore: update node version to 20 #6363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/Dockerfile.admin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# *****************************************************************************
# STAGE 1: Build the project
# *****************************************************************************
FROM node:18-alpine AS builder
FROM node:20-alpine AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Ensure consistent Node.js versions across all stages

Similar to space/Dockerfile.space, there's an inconsistency in Node.js versions across stages. The builder stage uses node:20-alpine while installer and runner stages use node:18-alpine.

Apply this diff to maintain version consistency:

# Stage 1
FROM node:20-alpine AS builder

# Stage 2
-FROM node:18-alpine AS installer
+FROM node:20-alpine AS installer

# Stage 3
-FROM node:18-alpine AS runner
+FROM node:20-alpine AS runner

Committable suggestion skipped: line range outside the PR's diff.

RUN apk add --no-cache libc6-compat
WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion space/Dockerfile.space
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# *****************************************************************************
# STAGE 1: Build the project
# *****************************************************************************
FROM node:18-alpine AS builder
FROM node:20-alpine AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Ensure consistent Node.js versions across all stages

While the builder stage has been updated to node:20-alpine, the installer and runner stages are still using node:18-alpine. This inconsistency could potentially lead to compatibility issues during the build process.

Apply this diff to maintain version consistency:

# Stage 1
FROM node:20-alpine AS builder

# Stage 2
-FROM node:18-alpine AS installer
+FROM node:20-alpine AS installer

# Stage 3
-FROM node:18-alpine AS runner
+FROM node:20-alpine AS runner

Committable suggestion skipped: line range outside the PR's diff.

RUN apk add --no-cache libc6-compat
WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion web/Dockerfile.web
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN turbo prune --scope=web --docker
# STAGE 2: Install dependencies & build the project
# *****************************************************************************
# Add lockfile and package.json's of isolated subworkspace
FROM node:18-alpine AS installer
FROM node:20-alpine AS installer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Ensure consistent Node.js versions across all stages and update builder stage

The Node.js version update is inconsistent:

  • Builder stage still uses node:18-alpine (missed update)
  • Installer stage uses node:20-alpine
  • Runner stage uses node:18-alpine

Apply this diff to maintain version consistency and update all stages:

# Stage 1
-FROM node:18-alpine AS builder
+FROM node:20-alpine AS builder

# Stage 2
FROM node:20-alpine AS installer

# Stage 3
-FROM node:18-alpine AS runner
+FROM node:20-alpine AS runner

Committable suggestion skipped: line range outside the PR's diff.


RUN apk add --no-cache libc6-compat
WORKDIR /app
Expand Down
Loading