[PE-228] fix: update tiptap package versions #6361
Conversation
WalkthroughThis pull request focuses on updating Tiptap library dependencies across multiple files in the project. The changes primarily involve upgrading versions of Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/editor/src/core/helpers/yjs-utils.ts (1)
15-18: Consolidate TypeScript error handling across the codebase.Multiple TypeScript errors are being suppressed in utility functions. Consider:
- Creating a central location for type definitions
- Documenting known type issues
- Planning for a proper fix in a follow-up PR
Also applies to: 59-60, 75-76, 104-105, 134-135
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
live/package.json(1 hunks)packages/editor/package.json(1 hunks)packages/editor/src/core/extensions/extensions.tsx(1 hunks)packages/editor/src/core/extensions/read-only-extensions.tsx(1 hunks)packages/editor/src/core/helpers/editor-commands.ts(3 hunks)packages/editor/src/core/helpers/yjs-utils.ts(5 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/editor/src/core/extensions/read-only-extensions.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/editor/src/core/extensions/extensions.tsx (1)
Line range hint
54-89: Good improvements to extension configuration and styling.The expanded configuration enhances the editor's appearance and accessibility through:
- Proper list styling and spacing
- Consistent heading and paragraph block classes
- Smooth dropcursor transition effects
packages/editor/package.json (3)
43-60: Ensure consistent versions across @tiptap packages.Most @tiptap packages are updated to 2.11.0, but some (@tiptap/core, @tiptap/extension-blockquote, @tiptap/extension-task-item) are at 2.10.4. This inconsistency might lead to compatibility issues.
Consider updating all packages to 2.11.0 for consistency, or verify that these specific versions are intentionally pinned.
43-60:⚠️ Breaking Changes Alert: Significant version updates in @tiptap packages.The updates from 2.1.x/2.3.x/2.6.x/2.7.x/2.8.x to 2.10.4/2.11.0 represent substantial version jumps that may introduce breaking changes. Please ensure:
- All editor features are thoroughly tested
- Release notes for each package have been reviewed
- Breaking changes are documented in the PR description
Run the following script to check for breaking changes in the release notes:
Line range hint
32-75: Verify the impact of removing react-moveable dependency.The
react-moveablepackage has been removed from dependencies. Please ensure:
- No components depend on this package
- Alternative implementation is in place if needed
Run the following script to check for any remaining usage:
✅ Verification successful
The removal of react-moveable dependency is safe
The package has been completely removed from the codebase with no remaining references or usage found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining references to react-moveable echo "Checking for react-moveable imports..." rg -l "react-moveable" --type ts --type tsx echo "Checking for Moveable component usage..." ast-grep --pattern 'import { Moveable } from "react-moveable"' ast-grep --pattern '<Moveable'Length of output: 347
Script:
#!/bin/bash # Description: Comprehensive check for react-moveable usage echo "Checking for any react-moveable references..." rg -l "react-moveable" --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type tsx --type ts echo -e "\nChecking for Moveable imports and usage..." rg "import.*['\"]react-moveable['\"]" --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type tsx --type ts echo -e "\nChecking for Moveable component references..." rg "Moveable" --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type tsx --type ts -A 2Length of output: 589
Description
This PR updates the tiptap packages to the latest stable version.
Type of Change
Summary by CodeRabbit
Dependency Updates
@tiptaplibrary dependencies to version2.11.0across multiple packagesreact-moveabledependency from editor packageCode Maintenance