[PE-228] chore: update @tiptap/extension-task-item version and required css
#6364
Conversation
WalkthroughThis pull request involves two primary changes: updating the version of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
aaryan610
changed the title
@tiptap/extension-task-item version and required css
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/editor/src/styles/editor.css (1)
Line range hint
122-179: Consider adding ARIA attributes for better accessibility.While the styling changes look good, consider adding appropriate ARIA attributes to enhance accessibility for screen readers.
ul[data-type="taskList"] li > label input[type="checkbox"] { + aria-label="Task checkbox" position: relative; -webkit-appearance: none; appearance: none;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
packages/editor/package.json(1 hunks)packages/editor/src/styles/editor.css(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (4)
packages/editor/package.json (1)
51-51: LGTM! Version update aligns with other tiptap extensions.The update from 2.10.4 to 2.11.0 brings @tiptap/extension-task-item in sync with other tiptap extensions.
Let's verify the changelog for any breaking changes:
✅ Verification successful
Version update is safe to proceed
The changelog for v2.11.0 shows only a bug fix for task-item extension (PR #5953) that improves the checked status updating functionality. No breaking changes were introduced.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the changelog for @tiptap/extension-task-item between versions 2.10.4 and 2.11.0 # Fetch the package information and changelog gh api graphql -f query=' { repository(owner: "ueberdosis", name: "tiptap") { releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC}) { nodes { tagName description } } } }'Length of output: 16191
packages/editor/src/styles/editor.css (3)
122-126: LGTM! Improved checkbox selector using standard pseudo-class.The change from
[checked]attribute to:checkedpseudo-class is more idiomatic and aligns with the new tiptap task-item extension behavior.
128-131: LGTM! Consistent hover state selector.The hover state selector now consistently uses the
:checkedpseudo-class, maintaining the same styling behavior.
177-179: LGTM! Updated checkbox checkmark styling.The checkmark styling (::before pseudo-element) now correctly uses the
:checkedpseudo-class, completing the checkbox styling updates.
Description
This PR updates the
@tiptap/extension-task-itemversion to the latest.In addition, CSS for checked item is also updated to accommodate the latest changes made to the task item extension which no longer adds the
checkedattribute to the checkbox input, instead handles it programmatically.Type of Change
Summary by CodeRabbit
Dependencies
@tiptap/extension-task-itempackage to version 2.11.0Style