✨ Session keys #126
Merged
✨ Session keys #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notdanilo
force-pushed
the
feature/session-keys
branch
3 times, most recently
from
f3c469c to
2c71613
Compare
notdanilo
force-pushed
the
feature/session-keys
branch
3 times, most recently
from
54b1f7d to
8ad8603
Compare
notdanilo
force-pushed
the
feature/session-keys
branch
from
8ad8603 to
d9ca41a
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
38 file(s) reviewed, 60 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+91
to
+94
| "name": "valid_until", | ||
| "type": { | ||
| "option": "i64" | ||
| } |
There was a problem hiding this comment.
logic: valid_until is optional but no default expiration is enforced. This could lead to indefinite sessions if not properly handled in the implementation.
notdanilo
force-pushed
the
feature/session-keys
branch
2 times, most recently
from
a5d5a40 to
3928e4b
Compare
notdanilo
force-pushed
the
feature/session-keys
branch
from
3928e4b to
b465118
Compare
There was a problem hiding this comment.
Left a few questions in the review, but LGTM in general. Thanks @notdanilo
GabrielePicco
approved these changes
Feb 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add build-in support for session keys, so that systems execution can be delegated.
Solution
A built-in feature in Bolt, so that all systems can be delegated
Greptile Summary
This PR adds built-in session key support to the Bolt framework, enabling delegated execution of systems through a new GPL Session protocol integration.
session-keysdependency and GPL Session protocol implementation incrates/bolt-lang/Cargo.tomlandclients/bolt-sdk/src/generated/idl/gpl_session.jsonsessionTokenfield in Apply structFindSessionTokenPdaandCreateSessioninclients/bolt-sdk/src/index.ts@coral-xyz/anchor0.30.1 and@project-serum/anchor0.26.0) could cause conflicts💡 (4/5) You can add custom instructions or style guidelines for the bot here!