Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to change item tag #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ability to change item tag #43

wants to merge 8 commits into from

Commits on Oct 12, 2017

  1. Added tag property

    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    6b82425 View commit details
    Browse the repository at this point in the history

  2. Added tag property

    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    4246b97 View commit details
    Browse the repository at this point in the history

  3. Added tag parameter

    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    edce7a4 View commit details
    Browse the repository at this point in the history

  4. Changed the way data is added to tag 

    The wrong use of data as selector requires data attributes to be set in a manual way, instead using data parameter.
    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    4e4ad2a View commit details
    Browse the repository at this point in the history

  5. Update notifications.js

    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    6e5f863 View commit details
    Browse the repository at this point in the history

  6. Handle notifications counter value 

    The correct use for the counter when there aren´t notifications is not display 0, is display empty value. Then you can automatically hide a badge using css rule `:empty`. Also you can set the number zero using `:empty:before { content: "0" }`
    @Eseperio
    Eseperio authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    36d5aa7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Update notifications.js

    @Eseperio
    Eseperio authored Oct 13, 2017
    Configuration menu
    Copy the full SHA
    e34a864 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. Single quotes instead doube quotes

    @Eseperio
    Eseperio authored Oct 16, 2017
    Configuration menu
    Copy the full SHA
    0a17b3b View commit details
    Browse the repository at this point in the history