Ability to change item tag #43
Conversation
The wrong use of data as selector requires data attributes to be set in a manual way, instead using data parameter.
The correct use for the counter when there aren´t notifications is not display 0, is display empty value. Then you can automatically hide a badge using css rule `:empty`. Also you can set the number zero using `:empty:before { content: "0" }`
|
It's not clear to me why the encapsulating tag should be configurable on each message. Can you give an example how you use this? |
assets/notifications.js
Outdated
|
|
||
| html = $(self.opts.tag, { | ||
| class: "notification notification-" + object['type'] + " "+(object.seen ? 'notification-seen' : 'notification-unseen'), | ||
| "data-route":object['url'], |
There was a problem hiding this comment.
please use the object.url form, with an extra space before 'object'
single quotes instead of double quotes
There was a problem hiding this comment.
Ok, i don´t know why i used brackets in that object. Is a mistake
| @@ -205,6 +210,7 @@ public function registerAssets() | |||
| 'pollSeen' => !!$this->pollSeen, | |||
| 'pollInterval' => Html::encode($this->pollInterval), | |||
| 'counters' => $this->counters, | |||
| 'tag' => Html::beginTag($this->tag) | |||
| ]; | |||
There was a problem hiding this comment.
Instead of the user providing only the tag name, shouldn't we enable him to pass also attributes?
Maybe move the processing in the Javascript, I don't like that we're calling Yii just to get '<' '>'
There was a problem hiding this comment.
This is a little modification. I have seen that javascript template can be impoved in many ways. I have a few ideas, but now i´m busy with other projects. When i have time i´ll try to do it.
With this modification user can change the name of the tag used to wrap the notification.
It is an optional parameter in order to keep BC.
Also there is another little tweak. When there aren´t notifications counters now displays nothing instead 0.
This allows the user hide a badge when there are not notifications by using
:emptycss property.If you need to keep 0 number then use css rule
.counterclass:empty:before { content: "0"}The behavior of hiding a badge when it is empty is used by almost all admin templates.