Merge pull request #65 from mvz/fix-setters

Remove memoization from remaining resource attribute setters
maartenvanvliet · Aug 19, 2021 · 209b111 · 209b111
2 parents ad8d2e1 + d7348c7
commit 209b111
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 21 deletions.
diff --git a/lib/moneybird/resource/contact.rb b/lib/moneybird/resource/contact.rb
@@ -54,15 +54,15 @@ class Contact
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
 
     def custom_fields=(custom_fields)
-      @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
+      @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
     end
   end
 end

diff --git a/lib/moneybird/resource/documents/purchase_invoice.rb b/lib/moneybird/resource/documents/purchase_invoice.rb
@@ -35,7 +35,7 @@ class PurchaseInvoice
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
@@ -47,11 +47,11 @@ def details=(line_items)
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
 
     def payments=(payments)
-      @payments ||= payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) }
+      @payments = payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) }
     end
   end
 end
diff --git a/lib/moneybird/resource/documents/receipt.rb b/lib/moneybird/resource/documents/receipt.rb
@@ -35,7 +35,7 @@ class Receipt
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
@@ -47,11 +47,11 @@ def details=(line_items)
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
 
     def payments=(payments)
-      @payments ||= payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) }
+      @payments = payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) }
     end
   end
 end
diff --git a/lib/moneybird/resource/estimate.rb b/lib/moneybird/resource/estimate.rb
@@ -48,15 +48,15 @@ class Estimate
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
-      @contact ||= Moneybird::Resource::Contact.build(attributes)
+      @contact = Moneybird::Resource::Contact.build(attributes)
     end
 
     def details=(line_items)
-      @details ||= line_items.map{ |line_item| Moneybird::Resource::Invoice::Details.build(line_item) }
+      @details = line_items.map{ |line_item| Moneybird::Resource::Invoice::Details.build(line_item) }
     end
   end
-end
+end
diff --git a/lib/moneybird/resource/external_sales_invoice.rb b/lib/moneybird/resource/external_sales_invoice.rb
@@ -38,7 +38,7 @@ class ExternalSalesInvoice
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
@@ -55,7 +55,7 @@ def details=(line_items)
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
   end
 end
diff --git a/lib/moneybird/resource/identity.rb b/lib/moneybird/resource/identity.rb
@@ -24,6 +24,6 @@ class Identity
   end
 
   def custom_fields=(custom_fields)
-    @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
+    @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
   end
 end
diff --git a/lib/moneybird/resource/recurring_sales_invoice.rb b/lib/moneybird/resource/recurring_sales_invoice.rb
@@ -40,7 +40,7 @@ class RecurringSalesInvoice
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
@@ -52,7 +52,7 @@ def details=(line_items)
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
   end
 end

diff --git a/lib/moneybird/resource/sales_invoice.rb b/lib/moneybird/resource/sales_invoice.rb
@@ -55,7 +55,7 @@ class SalesInvoice
     )
 
     def notes=(notes)
-      @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
+      @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) }
     end
 
     def contact=(attributes)
@@ -82,11 +82,11 @@ def details=(line_items)
     end
 
     def events=(events)
-      @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
+      @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) }
     end
 
     def custom_fields=(custom_fields)
-      @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
+      @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) }
     end
   end
 end