Skip to content

Commit

Permalink
Merge pull request #64 from ansdelft/master
Browse files Browse the repository at this point in the history
Update simplecov requirement from = 0.17 to = 0.21.2
  • Loading branch information
maartenvanvliet authored Jan 19, 2021
2 parents 76ec084 + 6d06798 commit ad8d2e1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
14 changes: 10 additions & 4 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ jobs:
with:
ruby-version: ${{ matrix.ruby_version }}

- uses: amancevice/setup-code-climate@v0
name: CodeClimate Install
with:
cc_test_reporter_id: 0b8e41ecbc26637a7db4e6e9d4581c445441674f689016ab45fb5c51242b59bf

- name: CodeClimate Pre-build Notification
run: cc-test-reporter before-build

- name: Build and test with Rake
env:
CI: true
Expand All @@ -26,7 +34,5 @@ jobs:
bundle install --jobs 4 --retry 3
bundle exec rake
- name: Publish code coverage
uses: paambaati/[email protected]
env:
CC_TEST_REPORTER_ID: 0b8e41ecbc26637a7db4e6e9d4581c445441674f689016ab45fb5c51242b59bf
- name: CodeClimate Post-build Notification
run: cc-test-reporter after-build
2 changes: 1 addition & 1 deletion moneybird.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |spec|

spec.add_development_dependency "bundler", [">= 1.11", "< 3.0"]
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "simplecov", "= 0.17"
spec.add_development_dependency "simplecov", "= 0.21.2"
spec.add_development_dependency "minitest"
spec.add_development_dependency "webmock", "~> 3.1"
end
2 changes: 1 addition & 1 deletion spec/lib/moneybird/service/sales_invoice_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
})
end
it "will return download url" do
service.download_pdf(456).must_equal 'https://storage.moneybird.dev/036ce3bd95c725c04aa5b81ee9419f9b49246a4b91483c2ad913e31a99204fa6/36cabf4c517ca62001f1bd3c9e014b0cacb2f77e9c24ab432c72ca6dc1820b6e/download'
_(service.download_pdf(456)).must_equal 'https://storage.moneybird.dev/036ce3bd95c725c04aa5b81ee9419f9b49246a4b91483c2ad913e31a99204fa6/36cabf4c517ca62001f1bd3c9e014b0cacb2f77e9c24ab432c72ca6dc1820b6e/download'
end
end

Expand Down

0 comments on commit ad8d2e1

Please sign in to comment.