Implement optional bias constant #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new optional argument to the PID class which allows a constant output bias to be specified. If provided this bias is applied to the output before any output limits are applied. This can be useful for systems which require a non-zero output to maintain a steady-state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new optional argument to the PID class which allows a constant output bias to be specified. If provided this bias is applied to the output before any output limits are applied. This can be useful for systems which require a non-zero output to maintain a steady-state.
This new argument is optional and defaults to zero, so existing users of the package won't notice any changes. The implementation itself is also trivial.
I've been using a bias constant in a system I'm currently working on by using a
PIDinstance without output limits, then applying the bias and output limits myself, after calling the PID instance. This works fine, but it's definitiely neater and more efficient to be able to let the PID take care of all the limits internally.Interested to hear if you think this would be worth having @m-lundberg . Let me know if there's anything else I need to add to this PR. Thanks for your work on this package, I've found it great to work with!