Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR-LR Update Iron #482

Merged
merged 40 commits into from
Jan 24, 2024
Merged

SR-LR Update Iron #482

merged 40 commits into from
Jan 24, 2024

Conversation

Serafadam
Copy link
Collaborator

Overview

Author: @Serafadam

Issue

Issue link (if present): #471 #470
Issue description: Update out-of-the box experience for LR/SR/Wide users. Additionally add an options to attach NNs to sensor/stereo nodes
Related PRs

Changes

ROS distro: Iron
List of changes:

  • Add URDF setup for LR and SR
  • Automatically change ISP scaling parameter based on camera model to prevent unusable configurations
  • Custom ISP num/den for LR for better output syncing
  • Add NN enabling for individual sensors
  • Add Spatial NN to a stereo setup
  • Add parameter to enable/disable camera restart on lack of diagnostic data
  • Update NN publishers to provide correct frame ID based on set socket
  • Replace pass_tf_args_as_params with publish_tf_from_calibration argument for clarity
  • RSP's robot description param is now namespaced to be consistent with TF publisher

Testing

Hardware used: OAK-D-SR, OAK-D-LR, OAK-D-PRO-W (OV9872)
Depthai library version: 2.23

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

mattwilliamson and others added 30 commits May 26, 2023 17:09
* Add camera image orientation param

* Change sensor orientation parameter name

---------

Co-authored-by: leo2 <[email protected]>
* add intra-process comm

* add lazy publishing

* update sensor naming convention

* low bandwidth and rectification updates

* setisp3a to 10fps by default

* isp3a to false on mono cam
* add debug options to the launch file

* add preview width height params

* add depthai_filters to depthai-ros pkgs

* isp3a to false for color

* update nn resizing

* add rclcpp check
@Serafadam Serafadam merged commit 1950ae6 into iron Jan 24, 2024
6 checks passed
@Serafadam Serafadam deleted the sr-lr-update-iron branch January 24, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.