DM-44392: Drop use of Reach UI #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ae78ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonathansick
changed the title
This is no longer an accessible alert. We'd need to use aria-invalid="true" on the input and then aria-describedby on the input to connect to the id of the ErrorMessage component.
We realized we probably want to re-engineer GafaelfawrUserMenu around the Radix NavigationMenu. To make space for that new component, we'll rename the DropdownMenu-based component. This will probably get deleted later once the new user menu is commissioned.
This adds the component and a basic storybook based on the original GafaelfawrUserMenuDropdown component. We'll add the Radix Navigation Menu implementation next.
This is now semantically correct and accessible user menu. We still need to tweak the presentation of the menu content so it pop down below trigger.
jonathansick
force-pushed
the
tickets/DM-44392
branch
from
72e67b8
to
327d438
Compare
This makes the menu functional... but we haven't yet replicated all the fun animation functionality that's provided in the Radix example at https://www.radix-ui.com/primitives/docs/components/navigation-menu
This new menu is in the @lsst-sqre/squared package.
- It seems that the a selector on the nav bar is overriding the
specificity of the color rule on MenuLink, so I had to add important!
there. This needs to be fixed.
- Adjusted positioning of the drop down menu so it appears on the
screen.
This makes it easier to develop the user menu...
This should ensure that squared and rubin-style-dictionary are always rebuilt before running squareone in dev mode.
This was causing the menu bar to shift up after log in.
jonathansick
force-pushed
the
tickets/DM-44392
branch
from
5068dca
to
804baa5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reach UI is no longer maintained, unfortuantely, and it's blocking us from upgrading Node and Next. This PR removes usage of Reach components: