Version Packages #167
Merged
Version Packages #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![squareone-ci[bot]](https://avatars.githubusercontent.com/u/10158560?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
d1f081d
to
337fe86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
157d03dThanks @jonathansick! - Usage of Reach UI is now removed and replaced with Radix UI. The user menu now usesGafaelfawrUserMenufrom@lsst-sqre/squaredand is based on Radix UI's Navigation Menu component. It is customized here to work with the Gafaelawr API to show a log in button for the logged out state, and to show the user's menu with a default log out button for the logged in state. Previously we also used Reach UI for showing an accessible validation alert in the Times Square page parameters UI. For now we've dropped this functionality.Patch Changes
157d03d,f403ffd]:@lsst-sqre/[email protected]
Minor Changes
#166
157d03dThanks @jonathansick! - Created GafaelfawrUserMenu based on the Radix UI navigation-menu component. That's the right primitive for an accessible menu that uses<a>or NextLinkelements. The existing Gafaelfawr menu is nowGafaelfawrUserDropdownfor reference (it is based on Radix UI's dropdown menu, but is more appropriate as a menu of buttons.#168
f403ffdThanks @jonathansick! - Disable opening and closing the GafaelfawrUserMenu on hover. This is a better UX because it allows for less precise mousing when using the menu.