Skip to content

Commit

Permalink
Merge pull request #168 from lsst-sqre:tickets/DM-44392
Browse files Browse the repository at this point in the history
DM-44392: Prevent opening/closing GafaelfawrUserMenu on hover.
  • Loading branch information
jonathansick committed Jul 3, 2024
2 parents 78a2306 + f403ffd commit e204d8c
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/many-moles-join.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lsst-sqre/squared': minor
---

Disable opening and closing the GafaelfawrUserMenu on hover. This is a better UX because it allows for less precise mousing when using the menu.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const Default: Story = {
<SWRConfig value={{ provider: () => new Map() }}>
<GafaelfawrUserMenu {...args}>
<GafaelfawrUserMenu.Link href="#">
Account Settings
Account settings
</GafaelfawrUserMenu.Link>
<GafaelfawrUserMenu.Link href="#">
Security tokens
Expand Down
17 changes: 14 additions & 3 deletions packages/squared/src/components/GafaelfawrUserMenu/Menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,28 @@ export const Menu = ({ children, logoutHref, username }: MenuProps) => {
<MenuRoot>
<MenuList>
<RadixNavigationMenu.Item>
<MenuTrigger>
<MenuTrigger
onPointerMove={(event) => event.preventDefault()}
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
>
{username} <ChevronDown />
</MenuTrigger>
<MenuContent>
<MenuContent
onPointerMove={(event) => event.preventDefault()}
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
>
{children}
<MenuLink href={logoutHref}>Log out</MenuLink>
</MenuContent>
</RadixNavigationMenu.Item>
</MenuList>
<ViewportContainer>
<ContentViewport />
<ContentViewport
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
/>
</ViewportContainer>
</MenuRoot>
);
Expand Down

0 comments on commit e204d8c

Please sign in to comment.