Skip to content

Commit

Permalink
Disable opening menu on hover
Browse files Browse the repository at this point in the history
This disables opening the navigation menu on hover, and instead requires
the user to click on the trigger to open it. This is generally a better
UX because it means that the menu stays open without the user needing to
have precise mousing.
  • Loading branch information
jonathansick committed Jul 3, 2024
1 parent 824d4df commit f403ffd
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/many-moles-join.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lsst-sqre/squared': minor
---

Disable opening and closing the GafaelfawrUserMenu on hover. This is a better UX because it allows for less precise mousing when using the menu.
17 changes: 14 additions & 3 deletions packages/squared/src/components/GafaelfawrUserMenu/Menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,28 @@ export const Menu = ({ children, logoutHref, username }: MenuProps) => {
<MenuRoot>
<MenuList>
<RadixNavigationMenu.Item>
<MenuTrigger>
<MenuTrigger
onPointerMove={(event) => event.preventDefault()}
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
>
{username} <ChevronDown />
</MenuTrigger>
<MenuContent>
<MenuContent
onPointerMove={(event) => event.preventDefault()}
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
>
{children}
<MenuLink href={logoutHref}>Log out</MenuLink>
</MenuContent>
</RadixNavigationMenu.Item>
</MenuList>
<ViewportContainer>
<ContentViewport />
<ContentViewport
onPointerEnter={(event) => event.preventDefault()}
onPointerLeave={(event) => event.preventDefault()}
/>
</ViewportContainer>
</MenuRoot>
);
Expand Down

0 comments on commit f403ffd

Please sign in to comment.