Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46413: Fix setting the SquarebotSlackMessage.is_bot field #32

Draft
wants to merge 2 commits into
base: tickets/DM-45917
Choose a base branch
from
Draft

DM-46413: Fix setting the SquarebotSlackMessage.is_bot field #32

wants to merge 2 commits into from

Commits on Sep 19, 2024

  1. Fix setting the is_bot property 

    - It turns out that bot_id can be set on messaegs without the
  bot_message subtype. Therefore base is_bot on whether a bot_id is
  present.
- Stop using bot_id as user_id for bot messages, because they are in
  fact separate things. This forces us to consider the user field as
  nullable.
    @jonathansick
    jonathansick committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7b7370c View commit details
    Browse the repository at this point in the history

  2. Add bot_id to SquarebotSlackMessageValue 

    This makes the bot_id from bot-sent messages more accessible to
Squarebot consumers.
    @jonathansick
    jonathansick committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    068cef9 View commit details
    Browse the repository at this point in the history