DM-46413: Fix setting the SquarebotSlackMessage.is_bot field #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It turns out that bot_id can be set on messaegs without the bot_message subtype. Therefore base is_bot on whether a bot_id is present. - Stop using bot_id as user_id for bot messages, because they are in fact separate things. This forces us to consider the user field as nullable.
This makes the bot_id from bot-sent messages more accessible to Squarebot consumers.
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Sep 20, 2024
- Improves `is_bot` field in SlackMessageValue model See lsst-sqre/squarebot#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards-incompatible changes
SquarebotSlackMessageValue.useris now nullable. It will benullif the message is abot_messagesubtype.New features
SquarebotSlackMessageValue.bot_idto capture the ID of the app that send a bot message.Bug fixes
is_botproperty ofSquarebotSlackMessageValueto account for messages without thebot_messagesubtype, but which still have abot_idset.