[hmac,dv] Fix fifo_empty interrupt #25683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-velay
commented
Dec 17, 2024
•
martin-velay
commented
- linked to issue [hmac,dv] intr_state TB issue #24691
- where the interrupt state for fifo_empty field from the RAL against the RTL were not matching. This was the case when all the empty conditions were filled but at the same time a full is coming. It was just a matter of changing the condition order in the TB.
- fix also FIFO depth status by allowing +1 of tolerance as this is not super critical to be cycle accurate.
martin-velay
force-pushed
the
hmac_status_2
branch
from
15d9b58 to
0c2c4c1
Compare
vogelpi
approved these changes
Dec 21, 2024
|
@rswarbrick, any feedback? |
rswarbrick
reviewed
Jan 8, 2025
- linked to issue lowRISC#24691 - where the interrupt state for fifo_empty field from the RAL against the RTL were not matching. This was the case when all the empty conditions were filled but at the same time a full is coming. It was just a matter of changing the condition order in the TB. - fix also FIFO depth status by allowing +1 of tolerance as this is not super critical to be cycle accurate. Signed-off-by: Martin Velay <[email protected]>
martin-velay
force-pushed
the
hmac_status_2
branch
from
0c2c4c1 to
b314b52
Compare
rswarbrick
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.