Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add revise form #3111

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(website): add revise form #3111

merged 1 commit into from
Oct 30, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Oct 29, 2024

resolves #3092

preview URL: https://revise-form.loculus.org/

Summary

image

I don't currently understand how a test could be added in our current paradigm: #1315

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Oct 29, 2024
@anna-parker anna-parker added preview Triggers a deployment to argocd and removed preview Triggers a deployment to argocd labels Oct 30, 2024
@anna-parker anna-parker added preview Triggers a deployment to argocd and removed preview Triggers a deployment to argocd labels Oct 30, 2024
@anna-parker
Copy link
Contributor

anna-parker commented Oct 30, 2024

@theosanderson this looks amazing - yesterday I tested a bit but the preview went down. I am documenting my testing here now:

Testing comments:

  • LOC_000PD32.1: revised metadata
  • LOC_000PD24.1: revised sequence
  • LOC_000PCWG.1: revised metadata and sequence

Confirmed these were not overwritten by ingest during reingest: this is due to the hash not being changed by the form:
image

Furthermore, the form doesn't even allow curators to change the hash (this isn't a listed field), so using this approach we will not run into: #3084 - we only need to make sure that ingest can handle the edge case in #3085 (or if a superuser accidentally curates via the revise page and doesn't use original metadata).

Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Theo! This looks really great! Also the tests I did look good I was wondering though if you could still verify my understanding a bit.
So here when you call the editPage when clicking the revise button - am I correct in understanding this is sending a get-data-to-edit request to the backend? (e.g. here: https://github.com/loculus-project/loculus/blob/1b7ce069b9b51e8e23d5ec000aa96365318eeab5/website/src/pages/%5Borganism%5D/submission/edit/%5Baccession%5D/%5Bversion%5D.astro#L17C49-L17C62 - which gets the processed and original data from the backend for that sequence) - but we only display the original metadata that is specified in EditableOriginalDataProps.inputFields which comes from the config.

@theosanderson
Copy link
Member Author

That sounds about right! (Mostly the behaviour is just like the old edit page, just that it submits differently for the revision case and displays a different header!)

@theosanderson theosanderson merged commit f4e9dc9 into main Oct 30, 2024
21 checks passed
@theosanderson theosanderson deleted the revise-form branch October 30, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(webpage, revision): Add an edit button to sequences that a user can revise
2 participants