-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest, backend): do not approve curated revisions (by users other than insdc_ingest_user), send notification if ingest wants to revise a curated sequence #3124
Conversation
c2a6788
to
93d9864
Compare
Testing:
|
…ed revisions (by users other than insdc_ingest_user), send notification if ingest wants to revise a curated sequence.
fd6f342
to
2c93dea
Compare
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Show resolved
Hide resolved
Very cool stuff, this was on my backlog and I'm very grateful you've done already so much more! Still reviewing, but wanted to ask what you think about adding/modifying one or two backend tests to make the new behaviour tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, backend changes are very minimal, would just be good to keep things tested in backend.
Python is good, I didn't verify things super closely, but I trust your testing, the changes seem to be fairly small, mostly a refactor - the new logic is very localized I think, simply bailing when a sequence was ever touched by non-insdc_ingest_user.
resolves #3087, #3084, #2613
partially: #3085,
preview URL: https://insdc-curation-ingest-qui.loculus.org/
Summary
Screenshot
PR Checklist
There is no diff in the ebola-zaire, cchf and west nile metadata.
I see this in logs:
Somehow the slack hook was removed from the config, I had to add it back. Now we are notified: