chore(website tests): replace waitUntil: 'networkidle' with 'load' #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@corneliusroemer, as @fengelniederhammer, just would like to check in with you: do you see any reason why we should use |
corneliusroemer
force-pushed
the
replace-networkidle
branch
from
08b43ec
to
c16792a
Compare
chaoran-chen
approved these changes
May 6, 2024
|
It seems that switching to load really fixes things - when I replace it back with current networkidle I get errors again, e.g. here: https://github.com/loculus-project/loculus/actions/runs/8976554978/job/24653636458#step:22:31 |
theosanderson
pushed a commit
that referenced
this pull request
May 7, 2024
…1783) * chore(website/tests): replace waitUntil: 'networkidle' with 'load' (default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1782
Summary
I don't know much about playwright, but it seems that
loadis the most conservative way to wait andnetworkidleis discouraged.Test execution appears to become slightly slower - but that might be the cost of deflaking and should be worth it. If anyone wants to improve tests in other way, go ahead, but replacing discouraged features is a first step