chore(ci): Retry failing E2E tests once using retry action #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As before I'd raise the concern that this will cause us to check in flaky tests. (Will await the views of others) |
|
Hmm, flaky tests haven't been stopped by the current setup, not much seems to be done about them either other than rerunning ad hoc |
|
I wouldn't mind retrying once for now as long as we ensure that we take some time soonish (after launch) to improve the tests and remove the retry again. |
|
I think I've fixed some E2E flakiness via #1784 and #1783 While my E2E dev setup is terrible (inability to run E2E locally), the tests aren't that hard to read and playwright traces, docs and examples are useful enough to attempt some fixes, nonetheless. Closing this for now to encourage myself to do more E2E test fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up E2E takes long, so retrying once is effective to cut down on test times when things are flaky