Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock switch config #165

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Clock switch config #165

merged 1 commit into from
Sep 29, 2023

Conversation

gustavosr8
Copy link
Contributor

No description provided.

@gustavosr8 gustavosr8 marked this pull request as draft August 7, 2023 17:54
@gustavosr8 gustavosr8 changed the base branch from master to devel August 7, 2023 17:54
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 12 times, most recently from 2f49794 to dff183c Compare August 10, 2023 17:04
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 2 times, most recently from 42750ba to ee4c888 Compare August 16, 2023 15:38
@gustavosr8 gustavosr8 linked an issue Aug 16, 2023 that may be closed by this pull request
Configure clock switch via IPMI and save it to the FRU EEPROM #123
Closed
@gustavosr8 gustavosr8 self-assigned this Aug 16, 2023
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 2 times, most recently from 70e1405 to 29d2915 Compare August 23, 2023 12:18
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 4 times, most recently from 5289cf6 to f3e107e Compare August 31, 2023 12:54
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 2 times, most recently from 9209fc6 to 8bd8436 Compare September 27, 2023 13:57
@gustavosr8 gustavosr8 requested review from augustofg and removed request for augustofg September 27, 2023 16:37
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 2 times, most recently from b039402 to 7c7f651 Compare September 27, 2023 17:09
@gustavosr8 gustavosr8 marked this pull request as ready for review September 27, 2023 17:13
augustofg
augustofg requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@augustofg augustofg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove:

openMMC/port/board/afc-v4/board_config.c

Lines 26 to 28 in 3b7ae35

uint8_t clock_switch_default_config() {
}

https://github.com/lnls-dig/openMMC/blob/master/port/board/afc-bpm/v3_1/adn4604_usercfg.h

openMMC/port/board/afc-bpm/v3_1/payload.c

Lines 299 to 302 in 3b7ae35

#ifdef MODULE_ADN4604
/* Configure clock switch */
adn4604_init();
#endif

(do the same to the afc-timing port)

port/board/afc-bpm/v3_1/payload.c Outdated Show resolved Hide resolved
port/board/afc-timing/payload.c Outdated Show resolved Hide resolved
port/board/afc-bpm/v3_1/CMakeLists.txt Outdated Show resolved Hide resolved
port/board/afc-timing/CMakeLists.txt Outdated Show resolved Hide resolved
modules/adn4604.c Outdated Show resolved Hide resolved
modules/adn4604.c Show resolved Hide resolved
modules/adn4604.h Outdated Show resolved Hide resolved
modules/adn4604.h Show resolved Hide resolved
@gustavosr8 gustavosr8 force-pushed the clock-switch-config branch 7 times, most recently from 078cf97 to a02340b Compare September 28, 2023 16:37
augustofg
augustofg requested changes Sep 28, 2023
View reviewed changes
port/board/afc-v4/board_config.c Outdated Show resolved Hide resolved
augustofg
augustofg requested changes Sep 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@augustofg
Copy link
Member

👍

@gustavosr8 gustavosr8 merged commit 467a826 into devel Sep 29, 2023
6 checks passed
@gustavosr8 gustavosr8 deleted the clock-switch-config branch September 29, 2023 16:15
@augustofg augustofg mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustofg augustofg augustofg requested changes

Assignees

@gustavosr8 gustavosr8

Labels
afc-bpm afc-timing afcv4 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure clock switch via IPMI and save it to the FRU EEPROM
2 participants
@gustavosr8 @augustofg