Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal clock mux config #115

Closed

Conversation

kaolpr
Copy link
Contributor

@kaolpr kaolpr commented May 28, 2021

A minimal clocking mux configuration. Please note that we can't put clock_switch_default_config() in board_config() as there is no power supply for P3V3 at that point.

@kaolpr
Copy link
Contributor Author

kaolpr commented May 28, 2021

Additionally, this dangerous loop around writing those registers is related to #112. Maybe we could setup some error-handling macro?

@augustofg
Copy link
Member

Yes we've identified this issue with the P3V3 before and corrected it in our 'dirty' local branch, but your code seems cleaner. I'll do some checks here before merging.

Error handling is a problem with openMMC in general, I'm drafting a proposal to make it consistent (error return enum, error codes, error strings etc). From our tests the IDT 8V54816 worked reliably every time at least.

@augustofg
Copy link
Member

You should declare uint8_t clock_switch_default_config(void) in the board_config.h header to avoid compiler warnings.

@augustofg
Copy link
Member

You also should include board_config.hin the payload.c.

@augustofg
Copy link
Member

I'm closing this due to #165. Now the clock mux configuration is done via IPMI and saved in the RTC EEPROM.

@augustofg augustofg closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants