Integrate LLVM at e2402615a5a76d46a433dfcc1de10b38a1263c9d #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate LLVM at e2402615a5a76d46a433dfcc1de10b38a1263c9d Integrate StabelHLO at 8cd9444b78ccec3e42a4b21105a5a547c021e823
* TOSA 1.0 spec has a new pad shape for tosa.pad: https://www.mlplatform.org/tosa/tosa_spec.html#_pad * Update Torch to TOSA legalization for aten.constant_pad_nd according to the new shape in TOSA spec * Add new LIT test Signed-off-by: Justin Ngo <[email protected]> Change-Id: Id92eb342b7fbdb67c564acddb92c01eaf2e7b95a
* TOSA conv ops have a new acc_type attribute in TOSA 1.0 spec: https://www.mlplatform.org/tosa/tosa_spec.html#_conv2d * Add this new acc_type attribute to TOSA conv ops for aten.convolution legalization from Torch to TOSA * Add new LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ie32b4879d1e6070a9fd20b0aa04a54d79c025018
* Update tosa.tile with 'multiples' as an input of !tosa.shape instead of as an attribute. This is in alignment with TOSA 1.0 spec: https://www.mlplatform.org/tosa/tosa_spec.html#_tile * Add a temporary getTosaConstShape() function in TosaLegalizeUtils.h. This function will be removed when the permanent getTosaConstShape() function is available in mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h in a future LLVM bump in Torch-MLIR. * Update LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: I8c45160331d79e29b3df68cd74ad3bbd1b5a8042
nirvedhmeshram
pushed a commit
to iree-org/torch-mlir
that referenced
this pull request
Jan 24, 2025
nirvedhmeshram
added a commit
to iree-org/iree
that referenced
this pull request
Jan 25, 2025
There are no llvm reverts/cherry-picks. Bump llvm to llvm/llvm-project@95d993a Bumps stablehlo to openxla/stablehlo@c27ba67 torch-mlir carries forward fixes from llvm/torch-mlir#3982 Additional forward fixes at iree-org/torch-mlir@fd34bc5 Some C++ API changes to `getStridesAndOffset` from llvm/llvm-project#123465 --------- Signed-off-by: Nirvedh Meshram <[email protected]>
nirvedhmeshram
changed the title
sjarus
approved these changes
Jan 27, 2025
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this pull request
Feb 4, 2025
There are no llvm reverts/cherry-picks. Bump llvm to llvm/llvm-project@95d993a Bumps stablehlo to openxla/stablehlo@c27ba67 torch-mlir carries forward fixes from llvm/torch-mlir#3982 Additional forward fixes at iree-org/torch-mlir@fd34bc5 Some C++ API changes to `getStridesAndOffset` from llvm/llvm-project#123465 --------- Signed-off-by: Nirvedh Meshram <[email protected]> Signed-off-by: Hyunsung Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LLVM to
llvm/llvm-project@e240261
Update StableHlo to
openxla/stablehlo@8cd9444
Updates API calls from:
applyPatternsAndFoldGreedily->applyPatternsGreedilyapplyOpPatternsAndFold->applyOpPatternsGreedilyThis commit also inlines the
BufferizeTypeConverterin Torch-MLIRwhich has been removed from the LLVM project here:
llvm/llvm-project@2ff2e87.
This commit also updates the
AdjustCallingConventionspass in order toalign with the changes made for
TypeConverterupstream. Some of thetests from the
adjust-calling-conventions.mlirare disabled for thetime being since they are not supported even after making changes in the
pass. We will enable them once the
AdjustCallingConventionspass isfully functional in a seperate PR. The fix will be tracked by
#3983.
TOSA Updates Summary:
Update Torch to TOSA legalizations with TOSA 1.0 ops' forms from LLVM
hash 64edde66. Changes include:
TOSA Pad op's new shape requirement
TOSA Convolution ops' new acc_type
TOSA Tile with multiples as a !tosa.shape input
Signed-off-by: Vivek Khandelwal [email protected]
Co-authored-by: Justin Ngo [email protected]